Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/275#issuecomment-39138169
Overall, I think this looks pretty good. After you figure out the failing
tests, you should also whitelist a bunch of tests that were only failing
because we didn't have timestamp support.
I got the list below by running `sbt/sbt -Dspark.hive.alltests hive/test`
(this runs all tests even if they aren't on the whitelist) and looking in
`sql/hive/target/HiveCompatibilitySuite.passed`. You should also check out the
logs in `sql/hive/target/HiveCompatibilitySuite.failed` and
`sql/hive/target/HiveCompatibilitySuite.wrong` to make sure we aren't missing
any edge cases regarding timestamps.
```
+ "input14",
+ "input21",
+ "input_testsequencefile",
+ "insert1",
+ "insert2_overwrite_partitions",
+ "join32_lessSize",
+ "join_map_ppr",
+ "join_rc",
+ "lateral_view_outer",
+ "loadpart1",
+ "mapreduce1",
+ "mapreduce2",
+ "mapreduce4",
+ "mapreduce5",
+ "mapreduce6",
+ "mapreduce8",
+ "multi_insert_gby",
+ "multi_insert_gby3",
+ "multi_insert_lateral_view",
+ "orc_dictionary_threshold",
+ "orc_empty_files",
+ "orc_ends_with_nulls",
+ "parallel",
+ "parenthesis_star_by",
+ "partcols1",
+ "partition_serde_format",
+ "partition_wise_fileformat4",
+ "partition_wise_fileformat5",
+ "partition_wise_fileformat6",
+ "partition_wise_fileformat7",
+ "partition_wise_fileformat9",
+ "ppd2",
+ "ppd_clusterby",
+ "ppd_constant_expr",
+ "ppd_transform",
+ "rcfile_columnar",
+ "rcfile_lazydecompress",
+ "rcfile_null_value",
+ "rcfile_toleratecorruptions",
+ "rcfile_union",
+ "reduce_deduplicate",
+ "reduce_deduplicate_exclude_gby",
+ "reducesink_dedup",
+ "smb_mapjoin_6",
+ "smb_mapjoin_7",
+ "stats_aggregator_error_1",
+ "stats_publisher_error_1",
+ "transform_ppr1",
+ "transform_ppr2",
+ "udaf_histogram_numeric",
+ "udf8",
+ "union3",
+ "union33",
+ "union_remove_11",
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
