Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/275#issuecomment-39270714
This is looking pretty good! A few small comments:
- You should also add Timestamp to `ScalaReflection`.
- You will need to check in any new golden files (if there are any) that
were created in `sql/hive/src/test/resources/`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
