Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/158#issuecomment-39281328
Hey @RongGu and @haoyuan , thanks again for the latest updates. I pointed
out a few small naming issues to make sure the API is complete. Apart from
this, there are a few other things, but we can fix them in later pull requests:
- It would be good if the example wasn't Pi because Pi doesn't really
benefit from caching. Porting something like SparkLR over would be more
exciting.
- I don't think you addressed my previous feedback of not allowing Tachyon
to be combined with other storage modes (e.g. disk and in-heap memory). But we
can add code to disable those combinations later.
Anyway once you make a pass through these please let me know and I think we
can merge it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
