Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/158#discussion_r11194776
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -59,6 +57,17 @@ private[spark] class BlockManager(
private[storage] val memoryStore: BlockStore = new MemoryStore(this,
maxMemory)
private[storage] val diskStore = new DiskStore(this, diskBlockManager)
+ var tachyonInitialized = false
+ private[storage] lazy val tachyonStore: TachyonStore = {
+ val storeDir = conf.get("spark.tachyonStore.baseDir",
System.getProperty("java.io.tmpdir"))
--- End diff --
I'm a little confused on why we are specifying root-level directories to
use within Tachyon? Perhaps I am misunderstanding the intention of this code,
but it looks like tachyonStorePath will look something like
"/tmp/spark-aef88fef89ea/2", but that this will not be a path in the root file
system, but rather within Tachyon itself -- i.e., we are referring to the URI
`tachyon://localhost:19998/tmp/spark-aef88fef89ea/2`.
I suppose this makes sense, it's just really weird to use the
java.io.tmpdir to refer to a path within Tachyon, when it is really referring
to a path in the rootfs of the current system. Is this path actually going to
be stored in the rootfs, or within Tachyon itself?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
