Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/158#discussion_r11194857
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -248,8 +257,10 @@ private[spark] class BlockManager(
         if (info.tellMaster) {
           val storageLevel = status.storageLevel
           val inMemSize = Math.max(status.memSize, droppedMemorySize)
    +      val inTachyonSize = Math.max(status.tachyonSize, droppedMemorySize)
    --- End diff --
    
    The notion of droppedMemorySize is confusing to me, but it seems to be 
originally computed from here: 
https://github.com/RongGu/spark-1/blob/master/core/src/main/scala/org/apache/spark/storage/BlockManager.scala#L837
    
    It seems like this should be just
    `val inTachyonSize = status.tachyonSize`
    therefore, but I could easily just be misunderstanding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to