Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/266#discussion_r11319358
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala ---
@@ -26,8 +26,7 @@ import scala.reflect.ClassTag
*
* Under the hood, it uses our OpenHashSet implementation.
*/
-private[spark]
-class OpenHashMap[K >: Null : ClassTag, @specialized(Long, Int, Double) V:
ClassTag](
+class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V:
ClassTag](
--- End diff --
You should keep this `private[spark]`, we can still use it in sub packages.
Also, why did you need to remove the `>: Null`? I'll CC @rxin to see if this
can cause any problems. It might mean we don't get a reasonable "no value"
indicator here, so perhaps we should keep the `>: Null` and change the case
where this was not working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
