Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/266#discussion_r11322086
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala ---
@@ -26,8 +26,7 @@ import scala.reflect.ClassTag
*
* Under the hood, it uses our OpenHashSet implementation.
*/
-private[spark]
-class OpenHashMap[K >: Null : ClassTag, @specialized(Long, Int, Double) V:
ClassTag](
+class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V:
ClassTag](
--- End diff --
Yeah, it works OK as `private[spark]`. I'm not sure why I thought it had
been a problem before. I'll restore that. The `>: Null` bound was requiring
bounds in other common classes like `RDD` to be `>: Null`, which entailed a lot
of knock-on changes. (See below for a snippet.) Should I go for it?
I'll commit a change that addresses everything else, to start, and rebases.
```
[error]
/Users/srowen/Documents/spark/core/src/main/scala/org/apache/spark/partial/GroupedCountEvaluator.scala:35:
type arguments [T,Long] do not conform to class OpenHashMap's type parameter
bounds [K >: Null,V]
[error] extends ApproximateEvaluator[OpenHashMap[T,Long], Map[T,
BoundedDouble]] {
[error] ^
...
[error]
/Users/srowen/Documents/spark/core/src/main/scala/org/apache/spark/rdd/RDD.scala:806:
type arguments [T,Long] do not conform to class OpenHashMap's type parameter
bounds [K >: Null,V]
[error] def countPartition(iter: Iterator[T]):
Iterator[OpenHashMap[T,Long]] = {
[error] ^
...
[error] 20 errors found
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
