Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/332#discussion_r11331104
  
    --- Diff: project/SparkBuild.scala ---
    @@ -315,36 +315,37 @@ object SparkBuild extends Build {
       def coreSettings = sharedSettings ++ Seq(
         name := "spark-core",
         libraryDependencies ++= Seq(
    -        "com.google.guava"           % "guava"            % "14.0.1",
    -        "com.google.code.findbugs"   % "jsr305"           % "1.3.9",
    -        "log4j"                      % "log4j"            % "1.2.17",
    -        "org.slf4j"                  % "slf4j-api"        % slf4jVersion,
    -        "org.slf4j"                  % "slf4j-log4j12"    % slf4jVersion,
    -        "org.slf4j"                  % "jul-to-slf4j"     % slf4jVersion,
    -        "org.slf4j"                  % "jcl-over-slf4j"   % slf4jVersion,
    -        "commons-daemon"             % "commons-daemon"   % "1.0.10", // 
workaround for bug HADOOP-9407
    -        "com.ning"                   % "compress-lzf"     % "1.0.0",
    -        "org.xerial.snappy"          % "snappy-java"      % "1.0.5",
    -        "org.spark-project.akka"    %% "akka-remote"      % akkaVersion 
excludeAll(excludeNetty),
    -        "org.spark-project.akka"    %% "akka-slf4j"       % akkaVersion 
excludeAll(excludeNetty),
    -        "org.spark-project.akka"    %% "akka-testkit"     % akkaVersion % 
"test",
    -        "org.json4s"                %% "json4s-jackson"   % "3.2.6" 
excludeAll(excludeScalap),
    -        "it.unimi.dsi"               % "fastutil"         % "6.4.4",
    -        "colt"                       % "colt"             % "1.2.0",
    -        "org.apache.mesos"           % "mesos"            % "0.13.0",
    -        "commons-net"                % "commons-net"      % "2.2",
    -        "net.java.dev.jets3t"        % "jets3t"           % "0.7.1" 
excludeAll(excludeCommonsLogging),
    -        "org.apache.derby"           % "derby"            % "10.4.2.0"     
                % "test",
    -        "org.apache.hadoop"          % hadoopClient       % hadoopVersion 
excludeAll(excludeNetty, excludeAsm, excludeCommonsLogging, excludeSLF4J, 
excludeOldAsm),
    -        "org.apache.curator"         % "curator-recipes"  % "2.4.0" 
excludeAll(excludeNetty),
    -        "com.codahale.metrics"       % "metrics-core"     % 
codahaleMetricsVersion,
    -        "com.codahale.metrics"       % "metrics-jvm"      % 
codahaleMetricsVersion,
    -        "com.codahale.metrics"       % "metrics-json"     % 
codahaleMetricsVersion,
    -        "com.codahale.metrics"       % "metrics-graphite" % 
codahaleMetricsVersion,
    -        "com.twitter"               %% "chill"            % chillVersion 
excludeAll(excludeAsm),
    -        "com.twitter"                % "chill-java"       % chillVersion 
excludeAll(excludeAsm),
    -        "org.tachyonproject"         % "tachyon"          % "0.4.1-thrift" 
excludeAll(excludeHadoop, excludeCurator, excludeEclipseJetty, 
excludePowermock),
    -        "com.clearspring.analytics"  % "stream"           % "2.5.1"
    +        "com.google.guava"           % "guava"               % "14.0.1",
    +        "com.google.code.findbugs"   % "jsr305"              % "1.3.9",
    +        "log4j"                      % "log4j"               % "1.2.17",
    +        "org.slf4j"                  % "slf4j-api"           % 
slf4jVersion,
    +        "org.slf4j"                  % "slf4j-log4j12"       % 
slf4jVersion,
    +        "org.slf4j"                  % "jul-to-slf4j"        % 
slf4jVersion,
    +        "org.slf4j"                  % "jcl-over-slf4j"      % 
slf4jVersion,
    +        "com.typesafe"               %% "scalalogging-slf4j" % "1.0.1",
    +        "commons-daemon"             % "commons-daemon"      % "1.0.10", 
// workaround for bug HADOOP-9407
    +        "com.ning"                   % "compress-lzf"        % "1.0.0",
    +        "org.xerial.snappy"          % "snappy-java"         % "1.0.5",
    +        "org.spark-project.akka"    %% "akka-remote"         % akkaVersion 
excludeAll(excludeNetty),
    +        "org.spark-project.akka"    %% "akka-slf4j"          % akkaVersion 
excludeAll(excludeNetty),
    +        "org.spark-project.akka"    %% "akka-testkit"        % akkaVersion 
% "test",
    +        "org.json4s"                %% "json4s-jackson"      % "3.2.6" 
excludeAll(excludeScalap),
    +        "it.unimi.dsi"               % "fastutil"            % "6.4.4",
    +        "colt"                       % "colt"                % "1.2.0",
    +        "org.apache.mesos"           % "mesos"               % "0.13.0",
    +        "commons-net"                % "commons-net"         % "2.2",
    +        "net.java.dev.jets3t"        % "jets3t"              % "0.7.1" 
excludeAll(excludeCommonsLogging),
    +        "org.apache.derby"           % "derby"               % "10.4.2.0"  
                   % "test",
    +        "org.apache.hadoop"          % hadoopClient          % 
hadoopVersion excludeAll(excludeNetty, excludeAsm, excludeCommonsLogging, 
excludeSLF4J, excludeOldAsm),
    +        "org.apache.curator"         % "curator-recipes"     % "2.4.0" 
excludeAll(excludeNetty),
    +        "com.codahale.metrics"       % "metrics-core"        % 
codahaleMetricsVersion,
    +        "com.codahale.metrics"       % "metrics-jvm"         % 
codahaleMetricsVersion,
    +        "com.codahale.metrics"       % "metrics-json"        % 
codahaleMetricsVersion,
    +        "com.codahale.metrics"       % "metrics-graphite"    % 
codahaleMetricsVersion,
    +        "com.twitter"               %% "chill"               % 
chillVersion excludeAll(excludeAsm),
    +        "com.twitter"                % "chill-java"          % 
chillVersion excludeAll(excludeAsm),
    +        "org.tachyonproject"         % "tachyon"             % 
"0.4.1-thrift" excludeAll(excludeHadoop, excludeCurator, excludeEclipseJetty, 
excludePowermock),
    +        "com.clearspring.analytics"  % "stream"             % "2.5.1"
    --- End diff --
    
    nit: re-add space before the last % to align it again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to