Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/332#issuecomment-39695999
@marmbrus As it stands, this patch seems to give us both worlds
(unnecessarily): we wrap the logging statements in a closure and then use the
scala logging macro to determine if we should unwrap. However, if we were to
simply make the logInfo() arguments into plain Strings, wouldn't we also lose
the benefits of the Scala macro, since the string has already been materialized
as the argument of logInfo? Would adding an `@inline` annotation avoid this or
would we have to make our log* functions into macros themselves to avoid this
overhead while keeping the name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
