Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/366#discussion_r11423681
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
    @@ -36,6 +36,7 @@ private[spark] class LiveListenerBus extends 
SparkListenerBus with Logging {
       private val eventQueue = new 
LinkedBlockingQueue[SparkListenerEvent](EVENT_QUEUE_CAPACITY)
       private var queueFullErrorMessageLogged = false
       private var started = false
    +  private var sparkListenerBus: Option[Thread] = _
    --- End diff --
    
    This doesn't have to be an option, you can move the declaration of the 
thread up here, and do thread.start() in `start()`. Also, a better name for 
this would be something like `listenerThread`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to