Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/366#discussion_r11423726
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -884,6 +883,7 @@ class SparkContext(
           cleaner.foreach(_.stop())
           dagSchedulerCopy.stop()
           listenerBus.stop()
    +      eventLogger.foreach(_.stop())
    --- End diff --
    
    `listenerBus.stop()` should be moved all the way to the end of `sc.stop()`, 
in case there are listeners that block for a long time and prevent other 
components of Spark to stop. Perhaps `eventLogger.foreach(_.stop())` should go 
right after the listener bus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to