Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/325#discussion_r11471838
  
    --- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
    @@ -135,4 +136,6 @@ trait Logging {
     private object Logging {
       @volatile private var initialized = false
       val initLock = new Object()
    +  // SLF4JBridgeHandler.removeHandlersForRootLogger()
    --- End diff --
    
    Is this line not actually necessary? 
    
    If it turns out we need to directly call `SLF4JBrigeHandler` let's change 
the call to just use reflection and fail gracefully if it's not found on the 
classpath. It's not pretty but will be friendlier to downstream users. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to