Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/362#discussion_r11497757
  
    --- Diff: 
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala 
---
    @@ -366,8 +366,7 @@ class ApplicationMaster(args: 
ApplicationMasterArguments, conf: Configuration,
             finishReq.setAppAttemptId(appAttemptId)
             finishReq.setFinishApplicationStatus(status)
             finishReq.setDiagnostics(diagnostics)
    -        // Set tracking url to empty since we don't have a history server.
    -        finishReq.setTrackingUrl("")
    +        
finishReq.setTrackingUrl(sparkConf.get("spark.historyserver.address", ""))
    --- End diff --
    
    Maybe move the `trackingUrl` as a private val somewhere at the top for 
reuse? Right now this line is duplicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to