Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/362#discussion_r11536291
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -347,8 +347,8 @@ class ApplicationMaster(args:
ApplicationMasterArguments, conf: Configuration,
logInfo("finishApplicationMaster with " + status)
if (registered) {
- // Set tracking URL to empty since we don't have a history server.
- amClient.unregisterApplicationMaster(status, "" /* appMessage */ ,
"" /* appTrackingUrl */)
+ val trackingUrl = sparkConf.get("spark.historyserver.address", "")
--- End diff --
What do you mean the line is a duplicate? Its only used once in this file.
the spark.historyserver.address isn't used anywhere else in spark. There are 2
different ApplicationMaster files. One for yarn-alpha and one for yarn-stable
but currently they have no shared base class. We could move it up but since
its only being used here and this function is only called once I don't see the
need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
