Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/407#discussion_r11617460
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -96,6 +97,7 @@ class ALS private (
         private var lambda: Double,
         private var implicitPrefs: Boolean,
         private var alpha: Double,
    +    private var partitioner: Partitioner = null,
    --- End diff --
    
    Do not put partitioner in constructor args. Use setters and make the 
hashPartitioner default. Also, should separate userPartitioner/numUserBlocks 
and productPartitioner/numProductBlocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to