Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/407#discussion_r11617633
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
    @@ -167,11 +169,24 @@ class ALS private (
           this.numBlocks
         }
     
    -    val partitioner = new HashPartitioner(numBlocks)
    +    // Hash an integer to propagate random bits at all positions, similar 
to java.util.HashTable
    +    def hash(x: Int): Int = {
    --- End diff --
    
    Instead of implementing a hash function, shall we use some existing ones? 
For example, we may use `scala.util.hashing.byteswap32`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to