Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/421#discussion_r11779292
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressPage.scala ---
    @@ -41,10 +41,12 @@ private[ui] class JobProgressPage(parent: 
JobProgressTab) extends WebUIPage("")
           val now = System.currentTimeMillis
     
           val activeStagesTable =
    -        new StageTable(activeStages.sortBy(_.submissionTime).reverse, 
parent, parent.killEnabled)
    +        new StageTableBase(activeStages.sortBy(_.submissionTime).reverse,
    +          parent, parent.killEnabled)
           val completedStagesTable =
    -        new StageTable(completedStages.sortBy(_.submissionTime).reverse, 
parent)
    -      val failedStagesTable = new 
StageTable(failedStages.sortBy(_.submissionTime).reverse, parent)
    +        new 
StageTableBase(completedStages.sortBy(_.submissionTime).reverse, parent)
    +      val failedStagesTable = new 
FailedStageTable(failedStages.sortBy(_.submissionTime).reverse,
    +        parent)
    --- End diff --
    
    super small nit: I would put `new FailedStageTable` on a new line to be 
consistent with the other tables in lines above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to