Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/421#discussion_r11786735
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -143,6 +143,34 @@ private[ui] class StageTable(
</td>
<td
sorttable_customekey={shuffleReadSortable.toString}>{shuffleRead}</td>
<td
sorttable_customekey={shuffleWriteSortable.toString}>{shuffleWrite}</td>
- </tr>
+ }
+ }
+
+ /** Render an HTML row that represents a stage */
+ private def renderStageRow(s: StageInfo): Seq[Node] =
<tr>{stageRow(s)}</tr>
+}
+
+private[ui] class FailedStageTable(
+ stages: Seq[StageInfo],
+ parent: JobProgressTab,
+ killEnabled: Boolean = false)
+ extends StageTableBase(stages, parent, killEnabled) {
+
+ override protected lazy val columns = {
+ <th>Stage Id</th>
+ if (isFairScheduler) {<th>Pool Name</th>} else {}
+ <th>Description</th>
+ <th>Submitted</th>
+ <th>Duration</th>
+ <th>Tasks: Succeeded/Total</th>
+ <th>Shuffle Read</th>
+ <th>Shuffle Write</th>
+ <th>Failed Reason</th>
+ }
+
+ override protected def stageRow(s: StageInfo): Seq[Node] = {
+ val basicColumns = super.stageRow(s)
+ val failedReason = <td valign="middle">{s.failureReason.get}</td>
--- End diff --
Sorry, I didn't notice this before, but if for some reason failureReason is
not set we will get an obscure exception message for calling None.get. Could
you do a `getOrElse` with maybe a default value of `""`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
