Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/477#discussion_r11840021
--- Diff: python/pyspark/rddsampler.py ---
@@ -19,7 +19,7 @@
import random
class RDDSampler(object):
- def __init__(self, withReplacement, fraction, seed):
+ def __init__(self, withReplacement, fraction, seed=None):
--- End diff --
@smartnut007, @mateiz, if we should not use nanoTime as a seed, we should
not pass none to random.seed(None). random.seed(None) will use time.time().
As reply for your very first comment, I think consistency is important. But
it's just my opinion,
others may disagree with me. You should do what you think is right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
