Github user smartnut007 commented on a diff in the pull request:
https://github.com/apache/spark/pull/477#discussion_r11840558
--- Diff: python/pyspark/rddsampler.py ---
@@ -19,7 +19,7 @@
import random
class RDDSampler(object):
- def __init__(self, withReplacement, fraction, seed):
+ def __init__(self, withReplacement, fraction, seed=None):
--- End diff --
@advancedxy @mateiz
Actually the default python seed in random.seed(None) is the following
snippet and picking random.random() will go through these anyway. ( python
2.7.5 )
from binascii import hexlify as _hexlify
from os import urandom as _urandom
long(_hexlify(_urandom(16)), 16)
I generally think its better to leave these things to the language
implementors.
But, if we need the code to look similar, then I would follow the last
suggestion in RDDSampler.
if seed is None: seed = random.randint(0, sys.maxint)
here sys.maxint is arch specific and generally 64 bit on 64 bit machines.
Can you guys let me know which one ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
