Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/450#discussion_r11878199
--- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
@@ -86,10 +88,16 @@ private[spark] class FileLogger(
val logPath = logDir + "/" + fileName
val uri = new URI(logPath)
+ val defaultFs =
FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
+ val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
+
/* The Hadoop LocalFileSystem (r1.0.4) has known issues with syncing
(HADOOP-7844).
* Therefore, for local files, use FileOutputStream instead. */
val dstream = uri.getScheme match {
- case "file" | null =>
+ case null if isDefaultLocal =>
+ new FileOutputStream(uri.getPath, !overwrite)
+
+ case "file" =>
--- End diff --
Is there a case where the scheme is `file` but the default is not local?
That is, if `file` always implies local then we can combine these two cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
