Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/450#discussion_r11878822
--- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
@@ -86,10 +88,16 @@ private[spark] class FileLogger(
val logPath = logDir + "/" + fileName
val uri = new URI(logPath)
+ val defaultFs =
FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
+ val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
--- End diff --
That check wouldn't cover all cases. It would need to be:
((defaultFs == null || defaultFs == "file") && uri.getScheme == null)) ||
uri.getScheme == "file"
(Which, btw, is the same check the pattern matcher is doing.) At that point
I think the current code is more readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
