huaxingao commented on a change in pull request #26972: [SPARK-30321][ML] Log 
weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r362037331
 
 

 ##########
 File path: 
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
 ##########
 @@ -261,7 +264,8 @@ private[spark] object GradientBoostedTrees extends Logging 
{
       boostingStrategy: OldBoostingStrategy,
       validate: Boolean,
       seed: Long,
-      featureSubsetStrategy: String): (Array[DecisionTreeRegressionModel], 
Array[Double]) = {
+      featureSubsetStrategy: String,
+      instr: Option[Instrumentation]): (Array[DecisionTreeRegressionModel], 
Array[Double]) = {
 
 Review comment:
   Good point. I will update the code. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to