huaxingao commented on a change in pull request #26972: [SPARK-30321][ML] Log
weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#discussion_r362042204
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
##########
@@ -204,9 +204,10 @@ class GBTClassifier @Since("1.4.0") (
val boostingStrategy = super.getOldBoostingStrategy(categoricalFeatures,
OldAlgo.Classification)
val (baseLearners, learnerWeights) = if (withValidation) {
GradientBoostedTrees.runWithValidation(trainDataset, validationDataset,
boostingStrategy,
- $(seed), $(featureSubsetStrategy))
+ $(seed), $(featureSubsetStrategy), Some(instr))
Review comment:
I hope it's slightly better now after I added the default value ```instr:
Option[Instrumentation] = None```. The code here is still the same, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
