viirya commented on a change in pull request #26956: [SPARK-30312][SQL]
Preserve path permission and acl when truncate table
URL: https://github.com/apache/spark/pull/26956#discussion_r362653500
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -499,8 +499,35 @@ case class TruncateTableCommand(
val path = new Path(location.get)
try {
val fs = path.getFileSystem(hadoopConf)
+ val fileStatus = fs.getFileStatus(path)
+ // Not all fs impl. support these APIs.
+ val optPermission = Try(fileStatus.getPermission())
+ val optAcls = Try(fs.getAclStatus(path).getEntries)
+
fs.delete(path, true)
Review comment:
Now I retain permission and ACLs. I was doing `fs.setOwner` in first commit
for retaining path owner and group. But `fs.setOwner` throws exception because
it is only doable by super user.
In Hive code, since it is code running the metastore server, I think it is
running with enough permission to set owner/group. For Spark, we may not
running it with super user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
