viirya commented on a change in pull request #26956: [SPARK-30312][SQL]
Preserve path permission and acl when truncate table
URL: https://github.com/apache/spark/pull/26956#discussion_r362708973
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -499,8 +499,35 @@ case class TruncateTableCommand(
val path = new Path(location.get)
try {
val fs = path.getFileSystem(hadoopConf)
+ val fileStatus = fs.getFileStatus(path)
+ // Not all fs impl. support these APIs.
+ val optPermission = Try(fileStatus.getPermission())
+ val optAcls = Try(fs.getAclStatus(path).getEntries)
+
fs.delete(path, true)
Review comment:
I was concerned with the presto way on performance regression. For a table
which has many files/directories, deleting them one by one could be a
bottleneck.
If we add a config for retaining permission/ACLs when truncating table?
Users can choose to disable it and directly delete top directory (current
behavior) without retaining permission/ACLs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
