Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3861#discussion_r24644698
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -61,22 +68,31 @@ private[spark] class CoarseMesosSchedulerBackend(
       var driver: SchedulerDriver = null
     
       // Maximum number of cores to acquire (TODO: we'll need more flexible 
controls here)
    -  val maxCores = conf.get("spark.cores.max",  Int.MaxValue.toString).toInt
    +  val maxCores = conf.get("spark.cores.max", Int.MaxValue.toString).toInt
     
       // Cores we have acquired with each Mesos task ID
       val coresByTaskId = new HashMap[Int, Int]
       var totalCoresAcquired = 0
     
    -  val slaveIdsWithExecutors = new HashSet[String]
    +  val slaveStatuses = new HashMap[String, SlaveStatus]
    +
    +  val taskIdToSlaveId = HashBiMap.create[Int, String]()
    --- End diff --
    
    why use a special map here instead of just a normal hash map?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to