huaxingao commented on issue #27094: [SPARK-30419][ML][PySpark] Make IsotonicRegression extend Regressor URL: https://github.com/apache/spark/pull/27094#issuecomment-570819435 I think over. I didn't implement this correctly: the FeaturesType could be Vector too. Even though the Vector features are changed to Double before train and predict, it is not correct for me to use Type Double in ```class IsotonicRegression extends Regressor[Double, IsotonicRegression, IsotonicRegressionModel]``` I tried type parameter just now but had trouble with it. I looked the history and found out this is the reason why IsotonicRegression doesn't inherit from Regressor. I will take a look of other regression algorithms to see if there are any reasons they don't inherit from Regressor. I will be more cautious before submitting PR next time. Sorry.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
