vanzin commented on a change in pull request #26440:
[WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning &
preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r363469587
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -402,6 +408,27 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
scheduler.workerRemoved(workerId, host, message)
}
+ /**
+ * Mark a given executor as decommissioned and stop making resource offers
for it.
+ */
+ private def decommissionExecutor(executorId: String): Boolean = {
+ val shouldDisable = CoarseGrainedSchedulerBackend.this.synchronized {
+ // Only bother decommissioning executors which are alive.
+ if (isExecutorActive(executorId)) {
+ executorsPendingDecommission += executorId
Review comment:
I see you adding things to this set but didn't notice anywhere removing the
executor from it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
