vanzin commented on a change in pull request #26440:
[WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning &
preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r363470002
##########
File path: core/src/main/scala/org/apache/spark/util/SignalUtils.scala
##########
@@ -60,10 +60,11 @@ private[spark] object SignalUtils extends Logging {
if (SystemUtils.IS_OS_UNIX) {
try {
val handler = handlers.getOrElseUpdate(signal, {
- logInfo("Registered signal handler for " + signal)
+ logInfo("Registering signal handler for " + signal)
new ActionHandler(new Signal(signal))
})
handler.register(action)
+ logInfo("Registered signal handler for " + signal)
Review comment:
This seems unnecessary. If registration fails you'll get an error message
from the exception handler below, no? Then the previous message is enough for
the success case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
