cloud-fan commented on a change in pull request #26806: [SPARK-30183][SQL]
Disallow to specify reserved properties in CREATE NAMESPACE syntax
URL: https://github.com/apache/spark/pull/26806#discussion_r363645236
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2498,6 +2498,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ private def checkNamespaceProperties(
+ properties: Map[String, String],
+ ctx: ParserRuleContext): Map[String, String] = withOrigin(ctx) {
+ import SupportsNamespaces._
+ if (!conf.getConf(SQLConf.LEGACY_PROPERTY_NON_RESERVED)) {
+ properties.foreach {
+ case (PROP_LOCATION, _) =>
+ throw new ParseException(s"$PROP_LOCATION is a reserved" + s"
namespace property," +
Review comment:
why break down the string here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
