cloud-fan commented on a change in pull request #26806: [SPARK-30183][SQL]
Disallow to specify reserved properties in CREATE NAMESPACE syntax
URL: https://github.com/apache/spark/pull/26806#discussion_r363832515
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -864,6 +865,33 @@ class DataSourceV2SQLSuite
}
}
+ test("CreateNameSpace: reserved properties") {
+ withSQLConf((SQLConf.LEGACY_PROPERTY_NON_RESERVED.key, "false")) {
+ SupportsNamespaces.RESERVED_PROPERTIES.asScala.foreach { key =>
+ val exception = intercept[ParseException] {
+ sql(s"CREATE NAMESPACE testcat.reservedTest WITH
DBPROPERTIES('$key'='dummyVal')")
+ }
+ assert(exception.getMessage.contains(s"$key is a reserved namespace
property"))
+ }
+ }
+ withSQLConf((SQLConf.LEGACY_PROPERTY_NON_RESERVED.key, "true")) {
+ SupportsNamespaces.RESERVED_PROPERTIES.asScala.foreach { key =>
+ withNamespace("testcat.reservedTest") {
+ withTempDir { tmpDir =>
+ val noEffectVal = tmpDir.getCanonicalPath
Review comment:
since it's no effect, can we just use a dumb string like "foo"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
