cloud-fan commented on a change in pull request #27110: [SPARK-30439][SQL]
Support non-nullable column
URL: https://github.com/apache/spark/pull/27110#discussion_r364124273
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -505,23 +500,59 @@ public DataType newDataType() {
return newDataType;
}
- public boolean isNullable() {
- return isNullable;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
UpdateColumnType that = (UpdateColumnType) o;
- return isNullable == that.isNullable &&
- Arrays.equals(fieldNames, that.fieldNames) &&
+ return Arrays.equals(fieldNames, that.fieldNames) &&
newDataType.equals(that.newDataType);
}
@Override
public int hashCode() {
- int result = Objects.hash(newDataType, isNullable);
+ int result = Objects.hash(newDataType);
+ result = 31 * result + Arrays.hashCode(fieldNames);
+ return result;
+ }
+ }
+
+ /**
+ * A TableChange to update the nullability of a field.
+ * <p>
+ * The field names are used to find the field to update.
+ * <p>
+ * If the field does not exist, the change must result in an {@link
IllegalArgumentException}.
+ */
+ final class UpdateColumnNullability implements ColumnChange {
Review comment:
cc @rdblue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
