cloud-fan commented on a change in pull request #27110: [SPARK-30439][SQL]
Support non-nullable column
URL: https://github.com/apache/spark/pull/27110#discussion_r364125063
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/TableCatalogSuite.scala
##########
@@ -379,27 +379,12 @@ class TableCatalogSuite extends SparkFunSuite {
assert(table.schema == originalSchema)
val updated = catalog.alterTable(testIdent,
- TableChange.updateColumnType(Array("id"), LongType, true))
+ TableChange.updateColumnNullability(Array("id"), true))
val expectedSchema = new StructType().add("id", LongType).add("data",
StringType)
assert(updated.schema == expectedSchema)
}
- test("alterTable: update optional column to required fails") {
Review comment:
we do the check at Spark side now, catalog implementation doesn't need to
care about it. Besides, the catalog implementation being tested doesn't check
the safety of the type change either, because the check is done at spark side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
