rdblue commented on issue #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands URL: https://github.com/apache/spark/pull/26847#issuecomment-572653715 +1 for @gatorsmile's approach of using a WIP PR for initial review and later separating features from refactoring and other changes. I think that this should be reverted because there was a standing -1. That -1 was also echoed by @brkyvz and the same issue was later pointed out by @viirya. I think it was inappropriate to commit this in the first place, so it should be reverted. I also think that we should take a closer look at the proposal for how resolution should work, and whether we want to target that for the 3.0 release given that we have several issues that we want to solve before 3.0 and the resolution works as it is now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
