dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL]
Emit pre/post events for "Partition" methods in ExternalCatalogWithListener
URL: https://github.com/apache/spark/pull/27030#discussion_r364981019
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/events.scala
##########
@@ -204,61 +204,64 @@ case class RenameFunctionEvent(
newName: String)
extends FunctionEvent
-trait PartitionEvent extends DatabaseEvent {
- /**
- * Name of the table that was touched.
- */
- val name: String
-}
-
+/**
+ * Event fired when a partition is created, dropped, altered or renamed.
+ */
+trait PartitionEvent extends TableEvent
/**
* Event fired before a partition is created.
*/
-case class CreatePartitionPreEvent(database: String, name: String,
- parts: Seq[CatalogTablePartition]) extends
PartitionEvent
+case class CreatePartitionPreEvent(
+ database: String,
+ name: String) extends PartitionEvent
Review comment:
For the indentation, shall we put `extends PartitionEvent` into a new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
