dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL]
Emit pre/post events for "Partition" methods in ExternalCatalogWithListener
URL: https://github.com/apache/spark/pull/27030#discussion_r365496650
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogEventSuite.scala
##########
@@ -209,4 +209,65 @@ class ExternalCatalogEventSuite extends SparkFunSuite {
catalog.dropFunction("db5", "fn4")
checkEvents(DropFunctionPreEvent("db5", "fn4") :: DropFunctionEvent("db5",
"fn4") :: Nil)
}
+
+ testWithCatalog("partition") { (catalog, checkEvents) =>
+ // CREATE
+ val path1 = Files.createTempDirectory("db_")
+ val uri1 = preparePath(path1)
+
+ val dbDefinition = createDbDefinition()
+
+ val storage = CatalogStorageFormat.empty.copy(
+ locationUri = Option(uri1))
Review comment:
Is this table storage pointing db path? Maybe, do you want the following?
```scala
val path1 = Files.createTempDirectory("db_")
val path2 = Files.createTempDirectory(path1, "tbl_")
val uri1 = preparePath(path1)
val uri2 = preparePath(path2)
// CREATE
val dbDefinition = createDbDefinition(uri1)
val storage = CatalogStorageFormat.empty.copy(
locationUri = Option(uri2))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
