Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/509#discussion_r11915784
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -139,13 +139,13 @@ private[spark] class SecurityManager(sparkConf: 
SparkConf) extends Logging {
       private val sparkSecretLookupKey = "sparkCookie"
     
       private val authOn = sparkConf.getBoolean("spark.authenticate", false)
    -  private val uiAclsOn = sparkConf.getBoolean("spark.ui.acls.enable", 
false)
    +  private var uiAclsOn = sparkConf.getBoolean("spark.ui.acls.enable", 
false)
     
    +  private var viewAcls: Set[String] = _
       // always add the current user and SPARK_USER to the viewAcls
    -  private val aclUsers = 
ArrayBuffer[String](System.getProperty("user.name", ""),
    +  private val defaultAclUsers = 
ArrayBuffer[String](System.getProperty("user.name", ""),
    --- End diff --
    
    nit: this should just be a `Seq` (no need to make it mutable).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to