Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/509#discussion_r11915790
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -167,17 +168,23 @@ class HistoryServer(
        * directory. If this file exists, the associated application is 
regarded to be completed, in
        * which case the server proceeds to render the SparkUI. Otherwise, the 
server does nothing.
        */
    -  private def renderSparkUI(logDir: FileStatus, logInfo: EventLoggingInfo) 
{
    +  private def renderSparkUI(logDir: FileStatus, elogInfo: 
EventLoggingInfo) {
         val path = logDir.getPath
         val appId = path.getName
    -    val replayBus = new ReplayListenerBus(logInfo.logPaths, fileSystem, 
logInfo.compressionCodec)
    +    val replayBus = new ReplayListenerBus(elogInfo.logPaths, fileSystem, 
elogInfo.compressionCodec)
    --- End diff --
    
    yes it collides with the logging logInfo so changed it.  I had some logInfo 
statements in there during development.  Left the name changed as I think its a 
bad idea for those to collide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to