HeartSaVioR commented on a change in pull request #27191: [SPARK-30495][SS]
Consider spark.security.credentials.kafka.enabled and cluster configuration
when checking latest delegation token
URL: https://github.com/apache/spark/pull/27191#discussion_r366061225
##########
File path:
external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaTokenUtilSuite.scala
##########
@@ -233,8 +233,27 @@ class KafkaTokenUtilSuite extends SparkFunSuite with
KafkaDelegationTokenTest {
assert(jaasParams.contains(tokenPassword1))
}
- test("isConnectorUsingCurrentToken without security should return true") {
- val kafkaParams = Map[String, Object]().asJava
+ test("isConnectorUsingCurrentToken without security credentials enabled
should return true") {
+ setSparkEnv(
+ Map(
+ s"spark.security.credentials.kafka.enabled" -> "false"
+ )
+ )
+ val kafkaParams = getKafkaParams(true, Some("custom_jaas_config"))
+
+ assert(KafkaTokenUtil.isConnectorUsingCurrentToken(kafkaParams, None))
+ }
+
+ test("isConnectorUsingCurrentToken without cluster config should return
true") {
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
