gaborgsomogyi commented on a change in pull request #27191: [SPARK-30495][SS]
Consider spark.security.credentials.kafka.enabled and cluster configuration
when checking latest delegation token
URL: https://github.com/apache/spark/pull/27191#discussion_r366225699
##########
File path:
external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaTokenUtilSuite.scala
##########
@@ -233,8 +233,27 @@ class KafkaTokenUtilSuite extends SparkFunSuite with
KafkaDelegationTokenTest {
assert(jaasParams.contains(tokenPassword1))
}
- test("isConnectorUsingCurrentToken without security should return true") {
- val kafkaParams = Map[String, Object]().asJava
+ test("isConnectorUsingCurrentToken without security credentials enabled
should return true") {
Review comment:
I see the potential from understanding point if view but don't see the
immediate need to differentiate between the 3 states: `true`, `false` and no
token. It would add more lines and complexity without actual value. `true`
means no action needed which fits for the usage now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
