beliefer commented on a change in pull request #27198:
[SPARK-27986][SQL][FOLLOWUP] Respect filter in sql/toString of
AggregateExpression
URL: https://github.com/apache/spark/pull/27198#discussion_r366165620
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -149,10 +149,24 @@ case class AggregateExpression(
case PartialMerge => "merge_"
case Final | Complete => ""
}
- prefix + aggregateFunction.toAggString(isDistinct)
+ val aggFuncStr = prefix + aggregateFunction.toAggString(isDistinct)
+ mode match {
+ case Partial | Complete if filter.isDefined =>
Review comment:
Although we made filter evaluated in first Aggregate.
I think there should just judge that the filter is defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
