beliefer commented on a change in pull request #27198:
[SPARK-27986][SQL][FOLLOWUP] Respect filter in sql/toString of
AggregateExpression
URL: https://github.com/apache/spark/pull/27198#discussion_r366183077
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -149,10 +149,24 @@ case class AggregateExpression(
case PartialMerge => "merge_"
case Final | Complete => ""
}
- prefix + aggregateFunction.toAggString(isDistinct)
+ val aggFuncStr = prefix + aggregateFunction.toAggString(isDistinct)
+ mode match {
+ case Partial | Complete if filter.isDefined =>
Review comment:
I mean the mode is `PartialMerge`.
If we only need to show filter in physical plans after rewrite, this is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
