Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4634#discussion_r24782383
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -25,17 +25,17 @@
import java.util.concurrent.*;
import org.apache.spark.input.PortableDataStream;
+import org.apache.spark.rdd.RDD;
+import org.apache.spark.serializer.KryoSerializer;
+import scala.collection.JavaConversions;
import scala.Tuple2;
import scala.Tuple3;
import scala.Tuple4;
-import com.google.common.collect.Iterables;
-import com.google.common.collect.Iterators;
-import com.google.common.collect.Lists;
-import com.google.common.collect.Maps;
import com.google.common.base.Throwables;
import com.google.common.base.Optional;
import com.google.common.base.Charsets;
+import com.google.common.collect.*;
--- End diff --
I'd reverse this ... I don't know whether we have a strong convention
either way about * and _ imports but I wouldn't change it just to change it.
Generally * is avoided in Java.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
