dongjoon-hyun commented on a change in pull request #27178:
[SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency
classifier
URL: https://github.com/apache/spark/pull/27178#discussion_r366685067
##########
File path: dev/test-dependencies.sh
##########
@@ -85,10 +85,15 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do
echo "Generating dependency manifest for $HADOOP_PROFILE"
mkdir -p dev/pr-deps
- $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath
-pl assembly \
- | grep "Dependencies classpath:" -A 1 \
- | tail -n 1 | tr ":" "\n" | rev | cut -d "/" -f 1 | rev | sort \
- | grep -v spark > dev/pr-deps/spark-deps-$HADOOP_PROFILE
+ $MVN $HADOOP2_MODULE_PROFILES -P$HADOOP_PROFILE dependency:build-classpath
-pl assembly | grep "Dependencies classpath:" -A 1 | tail -n 1 | tr ":" "\n" |
awk -F '/' '{
Review comment:
Let's keep the multi-line format. Especially, we don't need to change the
old line 88 and 89.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
