zero323 commented on a change in pull request #26247: [SPARK-29566][ML] Imputer 
should support single-column input/output
URL: https://github.com/apache/spark/pull/26247#discussion_r367166582
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala
 ##########
 @@ -205,6 +227,14 @@ class ImputerModel private[ml] (
 
   import ImputerModel._
 
+  /** @group setParam */
+  @Since("3.0.0")
+  def setInputCol(value: String): this.type = set(inputCol, value)
 
 Review comment:
   @viirya But then we're back to the question why we need `setInputCol` in  
`Models`. Should we support 
   
       Estimator.setInputCols(...).fit(...).setInputCol(...).transform(...)
   
   flow at all?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to