zero323 commented on a change in pull request #26247: [SPARK-29566][ML] Imputer
should support single-column input/output
URL: https://github.com/apache/spark/pull/26247#discussion_r367202597
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala
##########
@@ -205,6 +227,14 @@ class ImputerModel private[ml] (
import ImputerModel._
+ /** @group setParam */
+ @Since("3.0.0")
+ def setInputCol(value: String): this.type = set(inputCol, value)
Review comment:
Having option to overwrite `outputCol(s)` on can be useful to avoid name
clashes on pre-trained models.
But providing setters for inputs seems to be more confusing than useful, and
proliferation of `Params` that support both `Col` and `Cols` makes things even
more fuzzy, as there is no way to tell which variant we have, without
inspecting `Param` values.
In general I am asking because we seem to have cases like
`OneHotEncoderModel` - which provide `setInputCols` / `setOutputCols` but no
single column equivalents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
