dongjoon-hyun commented on a change in pull request #27230: [SPARK-27868][CORE]
Partially rollback previous change #09ed64d.
URL: https://github.com/apache/spark/pull/27230#discussion_r367718205
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
##########
@@ -108,8 +108,12 @@ public int numConnectionsPerPeer() {
return conf.getInt(SPARK_NETWORK_IO_NUMCONNECTIONSPERPEER_KEY, 1);
}
- /** Requested maximum length of the queue of incoming connections. Default
is 64. */
- public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, 64);
}
+ /**
+ * Requested maximum length of the queue of incoming connections. If < 1,
Review comment:
@xCASx . This PR has `< 1` here (line 112) and `-1` at line 114. Maybe,
`If set below 1,`like the documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
