xCASx commented on a change in pull request #27230:
[SPARK-27868][CORE][FOLLOWUP] Recover the default value to -1 again
URL: https://github.com/apache/spark/pull/27230#discussion_r367807661
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
##########
@@ -108,8 +108,12 @@ public int numConnectionsPerPeer() {
return conf.getInt(SPARK_NETWORK_IO_NUMCONNECTIONSPERPEER_KEY, 1);
}
- /** Requested maximum length of the queue of incoming connections. Default
is 64. */
- public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, 64);
}
+ /**
+ * Requested maximum length of the queue of incoming connections. If < 1,
Review comment:
[Here is how it
implemented](https://github.com/apache/spark/blob/09ed64d795d3199a94e175273fff6fcea6b52131/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java#L117):
```java
if (conf.backLog() > 0) {
bootstrap.option(ChannelOption.SO_BACKLOG, conf.backLog());
}
```
I've been thinking about wording. If use `0 or negative` instead of `< 1` it
may seem that separately mentioned `0` is some special case different to
`negative` values.
For me it's not a big deal, if you'd like, I can change it to `0 or
negative`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
