cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r367786052
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2916,14 +2916,14 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
* }}}
*/
override def visitAddTableColumns(ctx: AddTableColumnsContext): LogicalPlan
= withOrigin(ctx) {
- AlterTableAddColumnsStatement(
- visitMultipartIdentifier(ctx.multipartIdentifier),
+ AlterTableAddColumns(
+ UnresolvedTable(visitMultipartIdentifier(ctx.multipartIdentifier)),
Review comment:
yea that also works.
nit: we should skip relation lookup if the actual plan is already set. Or we
can introduce a new node `UnresolvedTableWithViewExists` to explicitly indicate
this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
